fix: update conversation data after edit #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lin Wang <[email protected]>
wanglam
force-pushed
the
fix-update-conversation-name-after-edit
branch
from
1f34092 to
e0267ac
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/agent-framework #48 +/- ##
===========================================================
+ Coverage 22.86% 30.48% +7.61%
===========================================================
Files 42 42
Lines 892 925 +33
Branches 221 228 +7
===========================================================
+ Hits 204 282 +78
+ Misses 681 636 -45
Partials 7 7 ☔ View full report in Codecov by Sentry. |
SuZhou-Joe
approved these changes
Dec 6, 2023
|
LGTM, but will be better that we add unit test to cover the fix. |
Signed-off-by: Lin Wang <[email protected]>
ruanyl
approved these changes
Dec 11, 2023
wanglam
merged commit fa7d6ff
into
opensearch-project:feature/agent-framework
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.